jonahgao commented on code in PR #13028:
URL: https://github.com/apache/datafusion/pull/13028#discussion_r1808305148
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -2799,14 +2817,71 @@ impl PartialOrd for Extension {
#[derive(Debug, Clone, PartialEq, Eq, PartialOrd, Hash)]
pub struct Limit {
/// Number of rows to skip before fetch
- pub skip: usize,
+ pub skip: Option<Box<Expr>>,
Review Comment:
Use `Box` here to prevent increasing the size of `LogicalPlan`, that
is`std::mem::size_of::<LogicalPlan>()`; otherwise it will cause a stack
overflow in one of the array_ndims
[test](https://github.com/apache/datafusion/blob/b42d9b81caddb5b53800f8eed32f9af4a9e3a01d/datafusion/sqllogictest/test_files/array.slt#L5152)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
