findepi commented on code in PR #13045:
URL: https://github.com/apache/datafusion/pull/13045#discussion_r1810549708
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -62,6 +62,11 @@ async fn run_tests() -> Result<()> {
env_logger::init();
let options: Options = clap::Parser::parse();
+ // nextest parses stdout
+ if options.list {
+ eprintln!("NOTICE: --list option unsupported quitting");
+ return Ok(());
Review Comment:
why Ok?
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -62,6 +62,11 @@ async fn run_tests() -> Result<()> {
env_logger::init();
let options: Options = clap::Parser::parse();
+ // nextest parses stdout
+ if options.list {
+ eprintln!("NOTICE: --list option unsupported quitting");
Review Comment:
```suggestion
eprintln!("NOTICE: --list option unsupported, quitting");
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
