alamb commented on code in PR #13045:
URL: https://github.com/apache/datafusion/pull/13045#discussion_r1810945149


##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -62,6 +62,11 @@ async fn run_tests() -> Result<()> {
     env_logger::init();
 
     let options: Options = clap::Parser::parse();
+    // nextest parses stdout
+    if options.list {
+        eprintln!("NOTICE: --list option unsupported quitting");
+        return Ok(());

Review Comment:
   Because if it returns an error, `cargo nextest` aborts immediately
   
   What is happening I think is that `nextest` lists all possible commands 
first (by running `cargo test ... --list --format terse`) and then uses that 
output to determine what is subsequently run. 
   
   So if the `--list` part returns an error then none of the tests run



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to