findepi commented on code in PR #13045:
URL: https://github.com/apache/datafusion/pull/13045#discussion_r1811361897
##########
datafusion/sqllogictest/bin/sqllogictests.rs:
##########
@@ -62,6 +62,15 @@ async fn run_tests() -> Result<()> {
env_logger::init();
let options: Options = clap::Parser::parse();
+ if options.list {
+ // nextest parses stdout, so print messages to stderr
+ eprintln!("NOTICE: --list option unsupported, quitting");
+ // return Ok, not error so that tools like nextest which are listing
all
+ // workspace tests (by running `cargo test ... --list --format terse`)
+ // do not fail when they encounter this binary. Instead, print nothing
+ // to stdout and return OK so they can continue listing other tests.
Review Comment:
❤️
a very good explanation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
