jayzhan211 commented on code in PR #12864:
URL: https://github.com/apache/datafusion/pull/12864#discussion_r1810729162
##########
datafusion/expr-common/src/type_coercion/binary.rs:
##########
@@ -529,6 +532,91 @@ fn type_union_resolution_coercion(
}
}
+pub fn try_type_union_resolution(data_types: &[DataType]) ->
Result<Vec<DataType>> {
+ let mut errors = vec![];
+ match try_type_union_resolution_with_struct(data_types) {
+ Ok(struct_types) => return Ok(struct_types),
+ Err(e) => {
+ errors.push(e);
+ }
+ }
+
+ if let Some(new_type) = type_union_resolution(data_types) {
+ Ok(vec![new_type; data_types.len()])
+ } else {
+ exec_err!("Fail to find the coerced type, errors: {:?}", errors)
+ }
+}
+
+// Handle struct where we only change the data type but preserve the field
name and nullability.
+// Since field name is the key of the struct, so it shouldn't be updated to
the common column name like "c0" or "c1"
+pub fn try_type_union_resolution_with_struct(
+ data_types: &[DataType],
+) -> Result<Vec<DataType>> {
+ let mut keys_string: Option<String> = None;
+ for data_type in data_types {
+ if let DataType::Struct(fields) = data_type {
+ let keys = fields.iter().map(|f| f.name().to_owned()).join(",");
Review Comment:
Since we are comparing those field names, whether the ',' is included in
field name doesn't matter. For example, if one of the field name is "a," and
",b", another is "a", ",b". We will compare "a,,,b" with "a,,b".
> Why not collect to Vec instead?
I think it works too, but so does string comparison
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
