findepi commented on code in PR #12864:
URL: https://github.com/apache/datafusion/pull/12864#discussion_r1811991048
##########
datafusion/optimizer/src/simplify_expressions/simplify_exprs.rs:
##########
@@ -417,7 +417,7 @@ mod tests {
Box::new(lit(1)),
));
let values = vec![vec![expr1, expr2]];
- let plan = LogicalPlanBuilder::values(values, None)?.build()?;
+ let plan = LogicalPlanBuilder::values_with_schema(values,
None)?.build()?;
Review Comment:
just `values(values)` since schema is None?
##########
datafusion/proto/src/logical_plan/mod.rs:
##########
@@ -282,7 +282,7 @@ impl AsLogicalPlan for LogicalPlanNode {
.map_err(|e| e.into())
}?;
- LogicalPlanBuilder::values(values, None)?.build()
+ LogicalPlanBuilder::values_with_schema(values, None)?.build()
Review Comment:
just `values(values)` since schema is None?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
