andygrove commented on code in PR #980:
URL: https://github.com/apache/datafusion-comet/pull/980#discussion_r1810985000
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -662,6 +662,10 @@ impl PhysicalPlanner {
let child = self.create_expr(expr.child.as_ref().unwrap(),
input_schema)?;
Ok(Arc::new(ToJson::new(child, &expr.timezone)))
}
+ ExprStruct::ToString(expr) => {
+ let child = self.create_expr(expr.child.as_ref().unwrap(),
input_schema)?;
+ Ok(Arc::new(To_String::new(child, &expr.timezone)))
Review Comment:
Could you change the name to `ToString` without the underscore?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
