andygrove commented on PR #980: URL: https://github.com/apache/datafusion-comet/pull/980#issuecomment-2447743171
Hi @adi-kmt. I just spent some time looking through this PR and I think there is some confusion that I can help with. The issue https://github.com/apache/datafusion-comet/issues/814 is for implementing CAST from struct to string. In SQL, this would look like `CAST(struct_value AS string)` rather than `to_string` (which does not seem to exist in Spark?). There should be no need to add additional protobuf types since we already have CAST supported there. `CometCastSuite` may be a good place to start with adding a test. Let me know if you have questions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
