Rachelint commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1819191554
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -287,6 +469,63 @@ where
};
}
+ fn vectorized_equal_to(
Review Comment:
> The same combination of `take` of some subset of rows is basically what
the arrow filter kernel does. However curently it only accepts a single array
as input --> single array as output.
>
> I wonder if we could implement some version of `filter` that that can be
invoked multiple times or something each time adding to the in-progress array.
>
> That might be the low level building block that generalized `take` and
`filter` and `interleave` (and we could use it as prt of `Repartition`) 🤔
🤔 It seems somethinng like `TakenArrayBuilder`?
And we input multiple `Array` and `taken indices` into it, and we call
`build` to get the final `Array`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
