Dandandan commented on code in PR #12996:
URL: https://github.com/apache/datafusion/pull/12996#discussion_r1819245889
##########
datafusion/physical-plan/src/aggregates/group_values/group_column.rs:
##########
@@ -287,6 +469,63 @@ where
};
}
+ fn vectorized_equal_to(
Review Comment:
I tried `interleave` as well before for `RepartitionExec`, but that has some
more overhead, as it needs to index both into the arrays by index as the values
in the arrays (so `take` + `concat` seemed to be faster as far as I remember).
> 🤔 It seems somethinng like TakenArrayBuilder?
> And we input multiple Array and taken indices pairs into it, and we call
build to get the final Array?
I guess yeah that could work both for aggregate and `RepartitionExec`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
