wugeer commented on code in PR #1472:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1472#discussion_r1822601096
##########
tests/sqlparser_common.rs:
##########
@@ -11460,3 +11460,49 @@ fn test_try_convert() {
all_dialects_where(|d| d.supports_try_convert() &&
!d.convert_type_before_value());
dialects.verified_expr("TRY_CONVERT('foo', VARCHAR(MAX))");
}
+
+#[test]
+fn parse_bang_not() {
+ let dialects = all_dialects_where(|d| d.supports_bang_not_operator());
+ let sql = "SELECT !a, !(b > 3)";
+ let Select { projection, .. } = dialects.verified_only_select(sql);
+
+ for (i, (op, expr)) in [
+ (
+ UnaryOperator::BangNot,
+ Box::new(Expr::Identifier(Ident::new("a"))),
+ ),
+ (
+ UnaryOperator::BangNot,
+ Box::new(Expr::Nested(Box::new(Expr::BinaryOp {
+ left: Box::new(Expr::Identifier(Ident::new("b"))),
+ op: BinaryOperator::Gt,
+ right:
Box::new(Expr::Value(Value::Number("3".parse().unwrap(), false))),
+ }))),
+ ),
+ ]
+ .into_iter()
+ .enumerate()
+ {
+ assert_eq!(
+ SelectItem::UnnamedExpr(Expr::UnaryOp { op: op, expr }),
+ projection[i]
+ )
+ }
+
+ let sql = "SELECT a!";
Review Comment:
Good catch! I will fix this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
