blaginin commented on PR #13177: URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2453031208
> It looks like the 2 implementations are comparable. Maybe the recursive approach + stacker is a bit faster when it comes to large trees (879 vs 915 ms). That's true! I also [checked](https://github.com/blaginin/datafusion/pull/1) your benchmark on different tree heights  Regarding your reasoning on `stacker`, I think we both agree that a library implementation would be less awkward, but the supporting argument still makes sense to me. @alamb, I think it should be your decision since you made the original point about recursion – I'm happy to submit a PR with `stacker` so we can further test it if needed -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
