alamb commented on PR #13177: URL: https://github.com/apache/datafusion/pull/13177#issuecomment-2462855289
> Well, I'm still on the side of keeping the recursive way and use `stacker` / `recursive` (like @blaginin implemented in this commit: [blaginin@9eaca84](https://github.com/blaginin/datafusion/commit/9eaca84383f510d03455f5cdd9ca3e2fcd3baa4e)) if we all can rely on that crate. My points are in this comment: [#13177 (comment)](https://github.com/apache/datafusion/pull/13177#issuecomment-2452940289). I am very worried about using `stacker` or some other similar crate -- while it sounds like it solves all the problems easily I have the following concerns: 1. It is not widely used (only 53 dependencies: https://crates.io/crates/stacker/reverse_dependencies) 2. It was dormant for over 2 years and only recently has started getting updates: https://crates.io/crates/stacker/versions 3. I worry it will cause some sort of hard to diagnose issue that appears only under load / memory pressure / etc -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
