yoavcloud commented on code in PR #1495:
URL: 
https://github.com/apache/datafusion-sqlparser-rs/pull/1495#discussion_r1826917925


##########
src/parser/mod.rs:
##########
@@ -11491,7 +11495,14 @@ impl<'a> Parser<'a> {
 
     /// Parse a TOP clause, MSSQL equivalent of LIMIT,
     /// that follows after `SELECT [DISTINCT]`.
-    pub fn parse_top(&mut self) -> Result<Top, ParserError> {
+    pub fn maybe_parse_top(
+        &mut self,
+        is_before_distinct: bool,
+    ) -> Result<Option<Top>, ParserError> {

Review Comment:
   Putting the positioning hint on the `SELECT` makes sense I was initially 
intimidated by introducing a change to such a central (the most central?) 
struct :-) See next commit



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to