iffyio commented on code in PR #1495:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1495#discussion_r1830855141
##########
src/parser/mod.rs:
##########
@@ -3534,7 +3534,9 @@ impl<'a> Parser<'a> {
pub fn parse_all_or_distinct(&mut self) -> Result<Option<Distinct>,
ParserError> {
let loc = self.peek_token().location;
let all = self.parse_keyword(Keyword::ALL);
- let distinct = self.parse_keyword(Keyword::DISTINCT);
+ let distinct = self
+ .parse_one_of_keywords(&[Keyword::DISTINCT, Keyword::DISTINCTROW])
+ .is_some();
Review Comment:
Alright that sounds good! We can remove the code for it (we have the keyword
and the associated parsing on this line)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
