yoavcloud commented on code in PR #1495:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1495#discussion_r1830495918
##########
src/parser/mod.rs:
##########
@@ -3534,7 +3534,9 @@ impl<'a> Parser<'a> {
pub fn parse_all_or_distinct(&mut self) -> Result<Option<Distinct>,
ParserError> {
let loc = self.peek_token().location;
let all = self.parse_keyword(Keyword::ALL);
- let distinct = self.parse_keyword(Keyword::DISTINCT);
+ let distinct = self
+ .parse_one_of_keywords(&[Keyword::DISTINCT, Keyword::DISTINCTROW])
+ .is_some();
Review Comment:
I decided it's best to remove this from the PR, as it's unrelated and I have
not done enough research on it. In MySQL, DISTINCTROW and DISTINCT are
synonymous but that's not true across all dialects. I'll add it in a future PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
