viirya commented on PR #1055: URL: https://github.com/apache/datafusion-comet/pull/1055#issuecomment-2477203280
> 1T q39a `(33349-28714)/33349 ~= 14%` 33349 obviously looks like it is affected by some noises. q44 avg diff is also ~ 5%. > The performance gain is proportional to the input size by design because it saves the overhead for all input arrow vectors. I mean it is less significant with longer query time. For queries running many minutes or hours, it has no difference. If this is a trivial change, it will be good. But as I took a quick look, the change is not small and doesn't look like in good design to me. I doubt that if it is worth. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
