alamb commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1844325454
########## datafusion/sqllogictest/test_files/scalar.slt: ########## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---- logical_plan -01)Projection: simple_string.letter, simple_string.letter = left(simple_string.letter2, Int64(1)) +01)Projection: simple_string.letter, simple_string.letter = left(CAST(simple_string.letter2 AS Utf8View), Int64(1)) Review Comment: 100% -- casts can often require trivial computation during query -- in this particular case casting `letter2` to a Utf8View means it will copy at least an additional 128 bytes for each row (each view is 128 bytes) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
