jiashenC commented on code in PR #13420: URL: https://github.com/apache/datafusion/pull/13420#discussion_r1844388835
########## datafusion/sqllogictest/test_files/scalar.slt: ########## @@ -1864,10 +1864,10 @@ query TT EXPLAIN SELECT letter, letter = LEFT(letter2, 1) FROM simple_string; ---- logical_plan -01)Projection: simple_string.letter, simple_string.letter = left(simple_string.letter2, Int64(1)) +01)Projection: simple_string.letter, simple_string.letter = left(CAST(simple_string.letter2 AS Utf8View), Int64(1)) Review Comment: Thanks for the suggestion. I implement not to cast if their logical types are the same. However, it is failing in some cases where `Dictionary` is in the signature. In those cases, the logical type is the same, but the native type is `Dictionary` causing type mismatch. The test can be reproduced ``` cargo test --test sqllogictests -- jctest ``` Any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
