Eason0729 commented on PR #1522: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1522#issuecomment-2480520257
> > Currently the preference is to avoid a third-party dependency for this issue, ideally fixing up the parser behavior instead to properly handle deeply nested input. See [comment here](https://github.com/apache/datafusion-sqlparser-rs/pull/1468#issuecomment-2414747574) for a bit more context on rationale From a quick look at recursive it seems to be a procmacro on top of the stacker library so that the same considerations should apply I imagine. > > @iffyio, we had done some research on stacker / recursive in https://github.com/apache/datafusion/pull/13310 to verify concerns before we added it to datafusion: https://github.com/apache/datafusion/pull/13310#pullrequestreview-2424590466 / https://github.com/apache/datafusion/pull/13177#issuecomment-2465457730 Sorry for missing that context when reviewing. So we would like to avoid using recursive for stablility, maybe try... 1. vender the code from recursive 2. use stacker directly, like https://github.com/apache/datafusion-sqlparser-rs/pull/1468 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
