blaginin commented on PR #1522: URL: https://github.com/apache/datafusion-sqlparser-rs/pull/1522#issuecomment-2501742493
@alamb, I feel like `recursion_limit` should stay because: - `recursive` doesn't solve the issue when `std` isn’t enabled. - Removing it would be a breaking change. - It can be a useful feature even with `recursive` protection, for example, if lib users have additional constraints on the parsed query. I added notes in the methods I touched; should be better now ✋ -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
