findepi commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845150639
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
List(Arc::new(Field::new("item", arg_types[0].clone(), true)))
}
+ Utf8View => List(Arc::new(Field::new("item", Utf8, true))),
Review Comment:
unclear to me -- if we're creating new string values, would there be benefit
of using Utf8View?
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -88,6 +90,7 @@ macro_rules! call_array_function {
($DATATYPE:expr, $INCLUDE_LIST:expr) => {{
match $DATATYPE {
DataType::List(_) => array_function!(ListArray),
+ DataType::Utf8View => array_function!(StringViewArray),
Review Comment:
nit: maybe put it _after_ DataType::Utf8 match branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
