findepi commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845182679


##########
datafusion/functions-nested/src/string.rs:
##########
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
             Utf8 | LargeUtf8 => {
                 List(Arc::new(Field::new("item", arg_types[0].clone(), true)))
             }
+            Utf8View => List(Arc::new(Field::new("item", Utf8, true))),

Review Comment:
   yes, indeed. is contrary also possible?
   also, isn't this the downstream function's problem, not here?
   
   ideally in https://github.com/apache/datafusion/issues/12622, utf8view would 
be run-time variant of utf8, same logical type, so next function could choose 
on its own



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org

Reply via email to