Omega359 commented on code in PR #13403:
URL: https://github.com/apache/datafusion/pull/13403#discussion_r1845170064
##########
datafusion/functions-nested/src/string.rs:
##########
@@ -251,20 +254,21 @@ impl ScalarUDFImpl for StringToArray {
Utf8 | LargeUtf8 => {
List(Arc::new(Field::new("item", arg_types[0].clone(), true)))
}
+ Utf8View => List(Arc::new(Field::new("item", Utf8, true))),
Review Comment:
If a function called after one of these functions were called that would
actually materially benefit from utf8view vs utf8 would it really matter. The
main difference in actual code would be requiring a different StringBuilder in
the `string_to_array_impl` function.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
