alamb commented on code in PR #13589:
URL: https://github.com/apache/datafusion/pull/13589#discussion_r1861976956
##########
datafusion/expr/src/logical_plan/tree_node.rs:
##########
@@ -710,13 +714,12 @@ impl LogicalPlan {
node: &LogicalPlan,
f: &mut F,
) -> Result<TreeNodeRecursion> {
- f(node)?
- .visit_children(|| {
- node.apply_subqueries(|c| apply_with_subqueries_impl(c, f))
- })?
- .visit_sibling(|| {
- node.apply_children(|c| apply_with_subqueries_impl(c, f))
- })
+ f(node)?.visit_children(|| {
+ node.apply_subqueries(|c| apply_with_subqueries_impl(c, f))?
+ .visit_sibling(|| {
Review Comment:
i don't fully understand this -- the `.visit_sibling` call looks like it is
in th `visit_children` closure now rather than being chained. Is that intended?
##########
datafusion/expr/src/logical_plan/plan.rs:
##########
@@ -4157,4 +4159,120 @@ digraph {
.unwrap();
assert_eq!(limit, new_limit);
}
+
+ #[test]
+ fn test_with_subqueries_jump() {
+ // The plan contains a `Project` node above a `Filter` node so
returning
Review Comment:
💯 comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
