peter-toth commented on PR #13589: URL: https://github.com/apache/datafusion/pull/13589#issuecomment-2505915082
> I verified test coverage by running the test without the code changes and it failed > > ``` > assertion failed: !filter_found > thread 'logical_plan::plan::tests::test_with_subqueries_jump' panicked at datafusion/expr/src/logical_plan/plan.rs:4179:9: > assertion failed: !filter_found > stack backtrace: > 0: rust_begin_unwind > at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/std/src/panicking.rs:662:5 > 1: core::panicking::panic_fmt > at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/panicking.rs:74:14 > 2: core::panicking::panic > at /rustc/f6e511eec7342f59a25f7c0534f1dbea00d01b14/library/core/src/panicking.rs:148:5 > 3: datafusion_expr::logical_plan::plan::tests::test_with_subqueries_jump > ``` Thanks so much @alamb for verifying this! Currently we don't return jump anywhere in `..._with_subqueries()`, but I plan on opening a proof of concept PR that will use it extensively and that's how I noticed the bug. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
