findepi commented on PR #13590: URL: https://github.com/apache/datafusion/pull/13590#issuecomment-2507810984
> So I went looking to see if there was a performant but portable float math library we could use. [libm](https://github.com/rust-lang/libm) seems to be it, it's what rustc uses when targeting WASM. why would we want to use it? are we changing the implementation just to write better test easier? exact double comparisons is a test problem, not the product problem, and should be solved in the test layer. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
