alamb commented on code in PR #13590:
URL: https://github.com/apache/datafusion/pull/13590#discussion_r1864241056
##########
datafusion/sqllogictest/test_files/aggregate_skip_partial.slt:
##########
@@ -261,11 +261,11 @@ SELECT c2, min(c5), max(c5), min(c11), max(c11) FROM
aggregate_test_100 GROUP BY
query IIR
SELECT c2, sum(c5), sum(c11) FROM aggregate_test_100 GROUP BY c2 ORDER BY c2;
----
-1 -438598674 12.153253793716
-2 -8259865364 9.577824473381
-3 1956035476 9.590891361237
-4 16155718643 9.531112968922
-5 6449337880 7.074412226677
+1 -438598674 12.15325379371643
Review Comment:
> And we need the results of sqllogicaltest complete mode to be the same
across different platforms. So the old scheme of rounding half to a certain
precision seems to be a good solution.
I agree
##########
Cargo.toml:
##########
@@ -92,7 +92,6 @@ arrow-ipc = { version = "53.3.0", default-features = false,
features = [
arrow-ord = { version = "53.3.0", default-features = false }
arrow-schema = { version = "53.3.0", default-features = false }
async-trait = "0.1.73"
-bigdecimal = "0.4.6"
Review Comment:
It is great to remove bigdecimal
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
