jonahgao commented on PR #13590: URL: https://github.com/apache/datafusion/pull/13590#issuecomment-2508009725
> If we value portability, I'd propose that we switch to `libm`, which is what I've implemented in the second commit. I think portability is not necessary, and [PostgreSQL](https://www.postgresql.org/docs/17/regress-evaluation.html#REGRESS-EVALUATION-FLOAT-DIFFERENCES) doesn't guarantee it either. I prefer to keep using std, as it should be more mature. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
