milenkovicm commented on code in PR #1144:
URL:
https://github.com/apache/datafusion-ballista/pull/1144#discussion_r1864367473
##########
ballista/core/src/serde/mod.rs:
##########
@@ -291,8 +294,11 @@ impl PhysicalExtensionCodec for
BallistaPhysicalExtensionCodec {
)?))
}
PhysicalPlanType::ShuffleReader(shuffle_reader) => {
+ let default_codec =
Review Comment:
would it make sense to make default_codec property
`BallistaPhysicalExtensionCodec`, so it can be overridden if needed?
`BallistaLogicalExtensionCodec` does similar thing. (also there is few other
places where `DefaultPhysicalCodec` is created)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
