onursatici commented on code in PR #1144:
URL:
https://github.com/apache/datafusion-ballista/pull/1144#discussion_r1876001066
##########
ballista/core/proto/ballista.proto:
##########
@@ -50,14 +50,15 @@ message ShuffleWriterExecNode {
message UnresolvedShuffleExecNode {
uint32 stage_id = 1;
datafusion_common.Schema schema = 2;
- uint32 output_partition_count = 4;
+ datafusion.Partitioning partitioning = 5;
Review Comment:
I thought there was a field with field number 3 in the past that got
deleted, so putting 3 for the new field would violate back compatibility. I
don't think we need to preserve back compat here though, not sure if there are
users that do rolling updates to their ballista scheduler and executors, but
wanted to be safe.
https://protobuf.dev/programming-guides/proto3/#consequences
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
