findepi commented on code in PR #13610:
URL: https://github.com/apache/datafusion/pull/13610#discussion_r1865687641
##########
datafusion/core/tests/parquet/mod.rs:
##########
@@ -45,7 +45,7 @@ use tempfile::NamedTempFile;
mod custom_reader;
mod external_access_plan;
mod file_statistics;
-#[cfg(not(target_family = "windows"))]
+// #[cfg(not(target_family = "windows"))]
Review Comment:
it's OK to just remove the line
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -223,7 +225,7 @@ async fn single_file() {
#[tokio::test]
async fn single_file_small_data_pages() {
- let tempdir = TempDir::new().unwrap();
+ let tempdir = TempDir::new_in(Path::new(".")).unwrap();
Review Comment:
could this end up litterring in the local git checkout when running the
tests?
##########
datafusion/core/src/test_util/parquet.rs:
##########
@@ -103,7 +103,17 @@ impl TestParquetFile {
let size = std::fs::metadata(&path)?.len() as usize;
- let canonical_path = path.canonicalize()?;
+ let mut canonical_path = path.canonicalize()?;
+
+ if cfg!(target_os = "windows") {
+ canonical_path = canonical_path
Review Comment:
is this test exercised on the CI?
https://github.com/apache/datafusion/blob/ddee4717af08e1cbeddf32f2872c3b6c8d378618/.github/workflows/rust.yml#L326-L339
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
