zhuliquan commented on code in PR #13610:
URL: https://github.com/apache/datafusion/pull/13610#discussion_r1867790168
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -223,7 +225,7 @@ async fn single_file() {
#[tokio::test]
async fn single_file_small_data_pages() {
- let tempdir = TempDir::new().unwrap();
+ let tempdir = TempDir::new_in(Path::new(".")).unwrap();
Review Comment:
> could this end up litterring in the local git checkout when running the
tests?
Emm, path which hold by `tempdir` will be delete after test case compeleted,
Because struct `TempDir` implements `Drop` trait.
```rust
impl Drop for TempDir {
fn drop(&mut self) {
if !self.keep {
let _ = remove_dir_all(self.path());
}
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
