zhuliquan commented on code in PR #13610:
URL: https://github.com/apache/datafusion/pull/13610#discussion_r1867844666
##########
datafusion/core/tests/parquet/filter_pushdown.rs:
##########
@@ -223,7 +225,7 @@ async fn single_file() {
#[tokio::test]
async fn single_file_small_data_pages() {
- let tempdir = TempDir::new().unwrap();
+ let tempdir = TempDir::new_in(Path::new(".")).unwrap();
Review Comment:
> can you perhaps try to undo this change? (same above)
Hi @findepi. It's a bummer, but we still have to make this change. Because,
I found out from the previous PR #13531 that the temp directory (i.g.
"C:\\Users\\RUNNER\~1\\AppData\\Local\\Temp") that contains the special
character `~` in CI, which will be replace to "%7E" when loading file, so that
the file cannot be find. I notice that some parquet cases are working fine on
windows machine (i.g.
`parquet::file_statistics::check_stats_precision_with_filter_pushdown`). This
cases read parquet files in "../../parquet-testing/data", which implies that
the current folder definitely ok and does not have special characters (i.g.
"~", "\\").
https://github.com/apache/datafusion/blob/fdb221fa645359b4bb65f600db1997ad6c865b65/datafusion/common/src/test_util.rs#L224-L229
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
