Weijun-H commented on code in PR #13611:
URL: https://github.com/apache/datafusion/pull/13611#discussion_r1867584562
##########
datafusion/optimizer/src/eliminate_duplicated_expr.rs:
##########
@@ -20,10 +20,9 @@
use crate::optimizer::ApplyOrder;
use crate::{OptimizerConfig, OptimizerRule};
use datafusion_common::tree_node::Transformed;
-use datafusion_common::Result;
+use datafusion_common::{IndexSet, Result};
use datafusion_expr::logical_plan::LogicalPlan;
use datafusion_expr::{Aggregate, Expr, Sort, SortExpr};
-use indexmap::IndexSet;
Review Comment:
I think it cannot be removed because of `indexmap::Equivalent`.
https://github.com/apache/datafusion/blob/0c01c0e688037d855a87d70b6b7025d91d62c077/datafusion/optimizer/src/join_key_set.rs#L151-L155
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
