jonahgao commented on PR #13611: URL: https://github.com/apache/datafusion/pull/13611#issuecomment-2516377818
> Can Clippy's disallowed types or methods be used to enforce consistency? We can add them to clippy [disallowed-types](https://github.com/apache/datafusion/blob/c62ab39a10eb50b4ed668b322d670660a82636f2/clippy.toml#L6). But I am a bit doubtful whether this PR is necessary because, unlike `HashMap`, indexmap does not have two implementations in DataFusion that need to be unified. I think `indexmap = { workspace = true }` already provides consistency. In addition, this type alias has added a permanent dependency for datafusion-common and can propagate to other packages. Even if one day, [common/cse.rs](https://github.com/apache/datafusion/blob/c62ab39a10eb50b4ed668b322d670660a82636f2/datafusion/common/src/cse.rs#L138) no longer needs `IndexMap`. We also need to create a type alias for [indexmap::Equivalent](https://github.com/apache/datafusion/blob/0c01c0e688037d855a87d70b6b7025d91d62c077/datafusion/optimizer/src/join_key_set.rs#L21) to ensure consistency. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
