findepi commented on PR #13611:
URL: https://github.com/apache/datafusion/pull/13611#issuecomment-2517764907
> I think `indexmap = { workspace = true }` already provides consistency.
I agree with that and also suggested in
https://github.com/apache/datafusion/pull/13611#issuecomment-2514087988
> In addition, this type alias has added a permanent dependency for
datafusion-common
good point.
common is pretty common to depend on, but also is too fat already (eg pulls
sqlparser dependency).
avoiding dependencies is a good thing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]