7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1870464718
##########
src/tokenizer.rs:
##########
@@ -1081,19 +1081,34 @@ impl<'a> Tokenizer<'a> {
.dialect
.is_proper_identifier_inside_quotes(chars.peekable.clone()) =>
{
- let error_loc = chars.location();
- chars.next(); // consume the opening quote
- let quote_end = Word::matching_end_quote(quote_start);
- let (s, last_char) = self.parse_quoted_ident(chars,
quote_end);
+ let word = if let Some(nested_quote_start) = self
+ .dialect
+ .nested_quote_start(quote_start,
chars.peekable.clone())
+ {
+ chars.next(); // consume the opening quote
Review Comment:
This code is RedShift specific (nested quotation). The same time
tokenisation of quoted identifier is a method of tokeniser and this is a reason
of implemented it here.
Let me know if you have a good idea how makes this code more explicit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
