iffyio commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1871749957
##########
src/dialect/redshift.rs:
##########
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then we assume
/// there is no json path.
fn is_proper_identifier_inside_quotes(&self, mut chars:
Peekable<Chars<'_>>) -> bool {
Review Comment:
Wondering why redshift is special with this, Im thinking since there are
other dialects that support jsonpath (which implements partiql in the parser)
it shouldn't be. Would it not be enough to remove this
`is_proper_identifier_inside_quotes` method entirely and the special `[`
character from `is_delimited_identifier_start`?
From what I can tell in [their
docs](https://docs.aws.amazon.com/redshift/latest/dg/r_names.html), `[` isn't
an identifier delimiter so it seems that having the dialect
`is_delimited_identifier_start` flag otherwise is incorrect?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
