7phs commented on code in PR #1576:
URL:
https://github.com/apache/datafusion-sqlparser-rs/pull/1576#discussion_r1872019394
##########
src/dialect/redshift.rs:
##########
@@ -41,14 +41,48 @@ impl Dialect for RedshiftSqlDialect {
/// treating them as json path. If there is identifier then we assume
/// there is no json path.
fn is_proper_identifier_inside_quotes(&self, mut chars:
Peekable<Chars<'_>>) -> bool {
Review Comment:
@iffyio I have updated the PR based on your suggestion. Now, a common quoted
identifier is processed without additional conditions, and RedShift uses the
same set of starting characters for quoted identifiers as PostgreSQL.
Additionally, I added a specific match to handle the RedShift-specific case
for `[`. All tests passed without requiring any changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
