jayzhan211 commented on PR #13717: URL: https://github.com/apache/datafusion/pull/13717#issuecomment-2533387874
`return_type_from_exprs` is introduced to avoid downstream breaking change, but if is still causes downstream breaking change...we should just cleanup these functions. Do you call `ScalarUDFImpl.return_type` for all the functions or just `date_part`? If you rely on `ScalarUDFImpl.return_type` for all the functions then I think we should deprecate `return_type_from_exprs` and fix the signature in `return_type`. If you can switch to `return_type_from_exprs` for `date_part` only, this is the better solution that minimize the breaking change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
