alamb commented on code in PR #13717:
URL: https://github.com/apache/datafusion/pull/13717#discussion_r1880208092
##########
datafusion/expr/src/udf.rs:
##########
@@ -174,6 +174,7 @@ impl ScalarUDF {
///
/// See [`ScalarUDFImpl::return_type`] for more details.
pub fn return_type(&self, arg_types: &[DataType]) -> Result<DataType> {
+ #[allow(deprecated)]
Review Comment:
Yes
##########
datafusion/expr/src/udf.rs:
##########
@@ -450,6 +451,7 @@ pub trait ScalarUDFImpl: Debug + Send + Sync {
/// is recommended to return [`DataFusionError::Internal`].
///
/// [`DataFusionError::Internal`]:
datafusion_common::DataFusionError::Internal
+ #[deprecated(since = "44.0.0", note = "Use `return_type_from_exprs`
instead")]
Review Comment:
if we are going to deprecate this API I think we should add an example to
`return_type_from_exprs` to help the migration effort.
I can help if we proceed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org
For additional commands, e-mail: github-h...@datafusion.apache.org
