andygrove commented on PR #13717: URL: https://github.com/apache/datafusion/pull/13717#issuecomment-2535904829
> `return_type_from_exprs` is introduced to avoid downstream breaking change, but if it still causes downstream breaking change...we should consider combine these 2 functions to cleanup. Both of these functions have been part of the public API for a while now. The newer `return_type_from_exprs` works correctly and the older `return_type` is incorrect in some cases. It seems better to me to deprecate the older incorrect version. > Do you call `ScalarUDFImpl.return_type` for all the functions or just `date_part`? We call this for all functions. > If you rely on `ScalarUDFImpl.return_type` for all the functions then I think we should deprecate `return_type_from_exprs` and fix the signature in `return_type`. If you can switch to `return_type_from_exprs` for `date_part` only, this is the better solution that minimize the breaking change. We have generic handling for all scalar UDFs so I'd prefer not to start adding special rules for specific funct ions. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
