leoyvens commented on PR #13590: URL: https://github.com/apache/datafusion/pull/13590#issuecomment-2538963790
> Use rounding in the SLT engine for all floats. Don't use rounding for decimal. In that case the potential valuable changes would be: 1. Somehow drop the bigdecimal dependency. 2. Use rounding that is compatible with what a DataFusion user would see. 3. More exact testing of decimals by dropping the rounding. I don't see how to do 1 while maintaining the Postgres-like rounding behaviour that is currently used in tests. Point 2 is a contradiction because a DataFusion user would not see any rounding, nor is there any UDF to emulate Postgres rounding. Point 3 is possibly nice but not enough to motivate me to pursue it. So I don't see anything to be done that would be sufficiently valuable to both my use case and upstream DataFusion at this point, so closing the PR. Thanks all for the reviews. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
