goldmedal commented on issue #13753: URL: https://github.com/apache/datafusion/issues/13753#issuecomment-2544774755
I summarized the proposal dependency, it will be like this  As @phillipleblanc said, Rust can't downcast to a `dyn trait`. I feel his proposal is good if we don't want to add the method to `UserDefinedLogicalNode` directly. > And then the Unparser has a Vec<Arc<dyn UserDefinedLogicalNodeUnparser>> that it uses to try to unparse UserDefinedLogicalNode > I guess this idea is similar to `ExprPlanner` for the logical planner. https://github.com/apache/datafusion/blob/bd2c975df88c9e95f2f6b5f2abed5638904e2ac0/datafusion/expr/src/planner.rs#L97-L98 So, `datafusion-unparser` will provide the builders and the trait, `UserDefinedLogicalNodeUnparser`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
