goldmedal commented on issue #13753: URL: https://github.com/apache/datafusion/issues/13753#issuecomment-2558404130
> I guess this idea is similar to `ExprPlanner` for the logical planner. > > https://github.com/apache/datafusion/blob/bd2c975df88c9e95f2f6b5f2abed5638904e2ac0/datafusion/expr/src/planner.rs#L97-L98 > > So, `datafusion-unparser` will provide the builders and the trait, `UserDefinedLogicalNodeUnparser`. I followed the design proposed by @phillipleblanc in #13880. I found we don't need to expose the builders for `datafusion-expr`. We can just public them in `datafusion-sql` for the user directly. So `datafusion-unparser` isn't required anymore. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
