vbarua commented on code in PR #13772:
URL: https://github.com/apache/datafusion/pull/13772#discussion_r1887845984
##########
datafusion/substrait/src/logical_plan/consumer.rs:
##########
@@ -994,8 +994,34 @@ pub async fn from_substrait_rel(
)
.await
}
- _ => {
- not_impl_err!("Unsupported ReadType: {:?}",
&read.as_ref().read_type)
+ Some(ReadType::ExtensionTable(ext)) => {
Review Comment:
I didn't actually get to handling ExtensionTables in
https://github.com/apache/datafusion/pull/13803, but I think I've got most what
we would need in place for it.
The way I would approach it, based on the work in that PR, is to add a
method to the `SubstraitConsumer` trait like:
```rust
async fn consume_extension_table(&self, extension_table: &ExtensionTable) ->
Result<LogicalPlan>
```
and wire it in here. Then, as a user you would be able to provide your own
implementation of the decoder. This _might_ user the SerializerRegistry, but it
doesn't necessarily need to.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
