vbarua commented on PR #13772: URL: https://github.com/apache/datafusion/pull/13772#issuecomment-2561479915
Left some feedback about the `consume_extension_table` API. > However, there are a few things that I'd like to revisit once we have a (symmetrical) customisable SubstraitProducer alongside the consumer. I'm planning on working that over the holidays https://github.com/apache/datafusion/issues/13901, so that might come round faster than you think. > I want to move away from the SerializerRegistry trait and provide full control to the user over the serialisation of the whole ReadRel in case of extension tables by working with proto objects directly instead of trying to model this as a generic serde concern. 100% > store the table name in (e.g.) ReadRel::common::hint::alias instead of abusing the proto::Any::type_url field of ExtensionTable::detail Honestly, if a user was doing this I would recommend that they store the name in the extension message directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
