ccciudatu commented on PR #13772: URL: https://github.com/apache/datafusion/pull/13772#issuecomment-2560986285
@vbarua I rebased on top of https://github.com/apache/datafusion/pull/13803 and added a `consume_extension_table` method to the `SubstraitConsumer` trait. I chose to pass the schema and projection to this method (instead of keeping the `TableScan` postprocessing in `from_read_rel`) to allow custom implementations to use that information for fully restoring their custom tables if needed. However, there are a few things that I'd like to revisit once we have a (symmetrical) customisable `SubstraitProducer` alongside the consumer. In particular, I want to move away from the `SerializerRegistry` trait and provide full control to the user over the serialisation of the whole `ReadRel` in case of extension tables by working with proto objects directly instead of trying to model this as a generic serde concern. This would allow the user to: 1. store the table name in (e.g.) `ReadRel::common::hint::alias` instead of abusing the `proto::Any::type_url` field of `ExtensionTable::detail` 2. Use the `ExtensionTable::detail::type_url` field to distinguish between multiple table implementations (as per the protobuf spec) 3. leverage the available ReadRel information that is currently unused (e.g. filtering, advanced extensions etc.) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
