adriangb commented on PR #13795: URL: https://github.com/apache/datafusion/pull/13795#issuecomment-2548934336
Here's a breakdown of how the clauses evaluate before and after this PR. *Before* | row_count = null_count | predicate | outcome | |------------------------|-----------|---------| | null | null | null | | null | true | true | | null | false | false | | true | null | false | | true | true | false | | true | false | false | | false | null | null | | false | true | true | | false | false | false | *After* | row_count = null_count | row_count != null_count | predicate | outcome | |------------------------|-------------------------|-----------|---------| | null | null | null | null | | null | null | true | null | | null | null | false | false | | true | false | null | false | | true | false | true | false | | true | false | false | false | | false | true | null | null | | false | true | true | true | | false | true | false | false | The only change is for the case where `row_count = null_count` is null and the predicate is `true`: previously `true` would be returned but now `null` is returned. Since we interpret `null` as `true` the end result is the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
